Add diagnosticReporter config option#1701
Merged
TwitchBronBron merged 6 commits intomasterfrom May 7, 2026
Merged
Conversation
Adds a new `diagnosticReporter` setting in bsconfig.json (and a matching
`--diagnostic-reporter` CLI flag) that lets users pick how diagnostics are
rendered to the console. Accepts a single value or an array, where each
value is a preset name ("detailed", "github-actions"), a custom template
string, or an explicit object form. Multiple reporters can run in the same
build so a CI run can emit detailed terminal output and GitHub Actions PR
annotations simultaneously without a third-party tool.
Invalid reporter values are logged and skipped rather than aborting the
build; if every configured reporter is invalid the build falls back to
"detailed". Schema and docs/bsconfig.md updated.
TwitchBronBron
approved these changes
May 6, 2026
chrisdp
commented
May 7, 2026
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/27a2c50d-7e45-4d54-a66c-e8dfeb705996 Co-authored-by: chrisdp <9591618+chrisdp@users.noreply.github.com>
chrisdp
commented
May 7, 2026
| "error" | ||
| ] | ||
| }, | ||
| "diagnosticReporter": { |
Contributor
There was a problem hiding this comment.
Fixed in c188846 — schema key is now diagnosticReporters.
chrisdp
commented
May 7, 2026
| //the resolved function is stashed on the entry as `run` so we don't have to keep a parallel array. | ||
| //invalid entries are warned about and skipped (we never want to abort a build over a config typo). | ||
| const reporters = diagnosticUtils.normalizeDiagnosticReporters( | ||
| this.options?.diagnosticReporters ?? this.options?.diagnosticReporter, |
Contributor
Author
There was a problem hiding this comment.
@copilot we should only have the option of diagnosticReporters
Contributor
There was a problem hiding this comment.
Done in e881d84 — singular support was removed so only diagnosticReporters is accepted (including CLI/docs/runtime resolution).
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/2a3f0f76-6c2f-49a0-bfd9-df4c3f608419 Co-authored-by: chrisdp <9591618+chrisdp@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/22914077-73e8-4652-b22a-c74b37805fbc Co-authored-by: chrisdp <9591618+chrisdp@users.noreply.github.com>
TwitchBronBron
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diagnosticReportersetting (and--diagnostic-reporterCLI flag) selecting how diagnostics are rendered:"detailed"(default),"github-actions", or a custom{file}:{line}: {message}template"detailed"(never aborts the build)